-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
폴더 목록 및 기본폴더 생성 #40
폴더 목록 및 기본폴더 생성 #40
Conversation
01e8d45
to
99a08ed
Compare
수고했어 형!! |
DEFAULT = 'default', | ||
|
||
/** 실제 DB에 들어가지는 않고 클라이언트에 내려주기 위해 있는 값 타입 */ | ||
ALL = 'all', | ||
FAVORITE = 'favorite', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 DEFAULT 인 폴더는 "나중에 읽을 링크" 만 있는건강 궁금쓰
export class FolderDomain { | ||
userId: string; | ||
|
||
name: string; | ||
|
||
type: FolderType; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도메인으로 따로 빼는 기준 궁금쓰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
없앰 ㅎㅎ
export interface FolderListServiceDto { | ||
/** */ | ||
defaultFolders: any[]; | ||
customFolders: any[]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일 이름은 안바뀌나욤?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바꿈
type: FolderType.ALL, | ||
userId: new MongooseSchema.Types.ObjectId(userId), | ||
postCount: allPostCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MongooseSchema 별칭 쓴 이유 궁금쓰
constructor(data: FolderDocument) { | ||
this.id = data._id.toString(); | ||
this.id = data._id ? data._id.toString() : data.id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_id가 없으면 data.id 주는거 맞징
근데 FolderDocument에 id가 없는것 같은데(any 타입 넘겨서) 임시로 해둔건가?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했어 !!! 👍
PR 내용
추가 및 변경 사항
PR 중점사항
스크린샷